-
Notifications
You must be signed in to change notification settings - Fork 76
feat: create RangeSlider component #8503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: slider-component
Are you sure you want to change the base?
Conversation
Add Slider Flow component wrapping <vaadin-slider> web component. The Slider extends AbstractSinglePropertyField and provides min, max, step, and value properties. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove explicit flow dependency versions from integration-tests pom.xml - Add README.md and LICENSE files - Add vite.config.ts for integration tests Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add tests for constructors, min/max/step properties, and validation that throws IllegalArgumentException for invalid values. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ider - Add ExperimentalFeatureException thrown when feature flag is disabled - Add feature flag check in Slider.onAttach - Add getMin, getMax, getStep methods to SliderElement - Add basic integration test verifying slider properties Co-Authored-By: Claude Opus 4.5 <[email protected]>
…rties - Create SliderBase<TComponent, TValue> abstract class extending AbstractSinglePropertyField - Move min, max, step getters/setters with validation to SliderBase - Update Slider to extend SliderBase<Slider, Double> Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move min, max, step tests to SliderBaseTest. Add tests for SliderBase constructors and value change listener constructors. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add a utility method to schedule actions that run before the client response, with deduplication by key. This allows deferring state validity checks until all property changes are complete. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Log warnings when setMin, setMax, or setStep is called and the current value becomes inconsistent with the new constraints. The warnings are deferred using beforeClientResponse to check the final state after all property changes in the current request are complete. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add tests verifying that warnings are logged when value doesn't align with min, max, or step constraints after property changes. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Change SliderBase constructor from protected to package-private. Update SliderTest to use the 4-parameter constructor with step value. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add constructors that use default step value of 1: - Slider(min, max, value) - Slider(min, max, value, listener) - Slider(label, min, max, value) - Slider(label, min, max, value, listener) Add corresponding unit tests verifying step defaults to 1. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add RangeSlider component that allows selecting a numeric range with two handles. Includes RangeSliderValue record for the start/end value pair and updates SliderBase to support custom value converters. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move the "start value cannot be greater than end value" validation from RangeSlider#setValue to the RangeSliderValue compact constructor, ensuring the invariant is enforced at construction time. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add RangeSliderTest with tests for constructors, setValue validation, interface implementations, and property setters/getters. Add RangeSliderSerializableTest for serialization testing. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add constructors with various parameter combinations including label, min/max range, step, initial value, and value change listener. Also add corresponding unit tests for all new constructors. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add RangeSliderElement testbench class and basic IT test that verifies min, max, step, and value properties are correctly set on the component. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update SliderBase to use SerializableBiFunction for value converters, allowing subclasses to access component state during conversion. Remove unused constructor and inline init method. Update Slider to validate values during conversion and throw exceptions for invalid min/max/step changes. Remove SliderWarningsTest as warnings are replaced with exceptions. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update RangeSlider to use SerializableBiFunction for value converters, allowing validation during conversion. Throw exceptions for invalid min/max/step changes instead of logging warnings. Remove RangeSliderWarningsTest as warnings are replaced with exceptions. Co-Authored-By: Claude Opus 4.5 <[email protected]>
TC Format Checker Report - 13:44 - 26 - Jan
Here is the list of files with format issues in your PR: |
|
3f0a565 to
344de3b
Compare




Description
Add RangeSlider component that allows selecting a numeric range with two handles. Includes RangeSliderValue record for the start/end value pair and updates SliderBase to support custom value converters.
Depends on
Fixes #8481
Type of change